GLUT: remove automatic ImGui::NewFrame() #6337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike all other backends' `ImGui_Impl_*_NewFrame()` functions, `ImGui_Impl_GLUT_NewFrame()` called `ImGui::NewFrame()`. This commit aims to make the GLUT backend consistent with the common interface. This is a breaking change, but possible assertion errors are easily fixable.
ocornut
pushed a commit
that referenced
this pull request
Apr 17, 2023
|
Thank you, this was indeed a mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike all other backends'
ImGui_Impl_*_NewFrame()functions,ImGui_Impl_GLUT_NewFrame()calledImGui::NewFrame(). This PR aims to make the GLUT backend consistent with the common interface. This is a breaking change, but possible assertion errors are easily fixable.Maybe this behavior is intended, I was unable to find any related issues or pull requests though.