csi driver installation #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppc64le-cloud-bot
added
the
size/M
Prajyot-Parab
added
the
kind/feature
|
@yussufsh Please take a look |
yussufsh
requested changes
Apr 7, 2022
mkumatag
requested changes
Apr 7, 2022
Prajyot-Parab
force-pushed
the
update
branch
3 times, most recently
from
9a6d6b9 to
b5a9ae0
Compare
ppc64le-cloud-bot
added
size/L
yussufsh
requested changes
Apr 14, 2022
Prajyot-Parab
force-pushed
the
update
branch
2 times, most recently
from
332ec6d to
a379f4c
Compare
yussufsh
reviewed
Apr 18, 2022
yussufsh
requested changes
Apr 18, 2022
ppc64le-cloud-bot
added
lgtm
|
/cc @sajauddin @cs-zhang |
yussufsh
previously approved these changes
Apr 21, 2022
mkumatag
requested changes
Apr 21, 2022
mkumatag
requested changes
Apr 21, 2022
| @@ -3,16 +3,19 @@ service_instance_id: "bc895dc9-f626-41c0-bfd3-94a0d8942a5f" #IBM Cloud PowerVS | |||
| region: "mon" #IBM Cloud PowerVS service instance region | |||
| zone: "mon01" #IBM Cloud PowerVS service instance zone | |||
|
|
|||
| csi_driver_type: "stable" #CSI driver type. | |||
There was a problem hiding this comment.
It will be good to add a comment how these values will be used to fetch the content here and in the README.md as well.
Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>
yussufsh
approved these changes
Apr 22, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkumatag, Prajyot-Parab, yussufsh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Prajyot-Parab prajyot.parab2@ibm.com