Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OWNERS #165

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Update OWNERS #165

merged 1 commit into from
Jun 3, 2022

Conversation

yussufsh
Copy link
Contributor

@yussufsh yussufsh commented May 31, 2022 •
edited
Loading

  1. Added @sajauddin as reviewer
  2. Added @cs-zhang as approver

@ppc64le-cloud-bot ppc64le-cloud-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 31, 2022
@sajauddin
Copy link
Collaborator

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2022
cs-zhang
cs-zhang reviewed May 31, 2022
View reviewed changes
Copy link
Collaborator

@cs-zhang cs-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add more approvers?

@yussufsh yussufsh force-pushed the yussufsh-patch-4 branch from 391a88c to fdec207 Compare June 2, 2022 05:10
@ppc64le-cloud-bot ppc64le-cloud-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2022
@yussufsh yussufsh requested a review from cs-zhang June 2, 2022 05:12
cs-zhang
cs-zhang approved these changes Jun 3, 2022
View reviewed changes
Copy link
Collaborator

@cs-zhang cs-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2022
sajauddin
sajauddin approved these changes Jun 3, 2022
View reviewed changes
Copy link
Collaborator

@sajauddin sajauddin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cs-zhang, sajauddin, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 411e844 into master Jun 3, 2022
@yussufsh yussufsh deleted the yussufsh-patch-4 branch June 9, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cs-zhang cs-zhang cs-zhang approved these changes

@sajauddin sajauddin sajauddin approved these changes

@Prajyot-Parab Prajyot-Parab Awaiting requested review from Prajyot-Parab

Assignees

@sajauddin sajauddin

@cs-zhang cs-zhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yussufsh @sajauddin @ppc64le-cloud-bot @cs-zhang