Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding eus to eus ocp upgrade #168

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Adding eus to eus ocp upgrade #168

merged 1 commit into from
Oct 25, 2022

Conversation

varad-ahirwadkar
Copy link

Signed-off-by: Varad Ahirwadkar varad.ahirwadkar@ibm.com

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 8, 2022
@varad-ahirwadkar
Copy link
Author

/cc @Prajyot-Parab

sajauddin
sajauddin reviewed Sep 16, 2022
View reviewed changes
Copy link
Collaborator

@sajauddin sajauddin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added lgtm Indicates that a PR is ready to be merged. do-not-merge/non-mergeable labels Sep 16, 2022
@Prajyot-Parab
Copy link
Collaborator

@varad-ahirwadkar what will be given preference if both upgrade and eus vars are set?

@varad-ahirwadkar
Copy link
Author

@varad-ahirwadkar what will be given preference if both upgrade and eus vars are set?

EUS vars will be used for intermediate upgrade and upgrade variables will be used for final upgrade.
So both kond of variables are required for eus upgrade if upgrade channel is non eus (eus-4.x)
So EUS upgrade will be triggered only if EUS variable eus_upgrade_channel or eus_intermediate_upgrade_image is set along with upgrade vars.
I will add one condition to check upgrade vars also.

@Rajalakshmi-Girish
Copy link
Contributor

@varad-ahirwadkar: PR is not mergeable.

The PR state is: BLOCKED

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ppc64le-cloud-bot ppc64le-cloud-bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2022
yussufsh
yussufsh requested changes Sep 20, 2022
View reviewed changes
examples/upgrade_vars.yaml Outdated Show resolved Hide resolved
playbooks/roles/ocp-upgrade/tasks/eus_upgrades.yaml Outdated Show resolved Hide resolved
@varad-ahirwadkar varad-ahirwadkar force-pushed the eus branch 2 times, most recently from 658229c to c1cb931 Compare September 22, 2022 04:49
@varad-ahirwadkar varad-ahirwadkar requested review from yussufsh and removed request for sudeeshjohn and Prajyot-Parab September 30, 2022 10:51
@varad-ahirwadkar
Copy link
Author

/cc @sudeeshjohn @Prajyot-Parab

@yussufsh
Copy link
Contributor

yussufsh commented Oct 4, 2022

/lgtm
/cc @pravin-dsilva

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2022
yussufsh
yussufsh previously approved these changes Oct 4, 2022
View reviewed changes
@ppc64le-cloud-bot ppc64le-cloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2022
Adding eus to eus ocp upgrade
7ab3796 
Signed-off-by: Varad Ahirwadkar <varad.ahirwadkar@ibm.com>
@ppc64le-cloud-bot ppc64le-cloud-bot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 18, 2022
@yussufsh
Copy link
Contributor

/approve
/cc @pravin-dsilva

@ppc64le-cloud-bot ppc64le-cloud-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/non-mergeable labels Oct 19, 2022
@pravin-dsilva
Copy link
Collaborator

/approve

@ppc64le-cloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pravin-dsilva, varad-ahirwadkar, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yussufsh
Copy link
Contributor

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2022
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit ba91711 into ocp-power-automation:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sajauddin sajauddin sajauddin left review comments

@yussufsh yussufsh yussufsh left review comments

@Prajyot-Parab Prajyot-Parab Awaiting requested review from Prajyot-Parab

@sudeeshjohn sudeeshjohn Awaiting requested review from sudeeshjohn

@pravin-dsilva pravin-dsilva Awaiting requested review from pravin-dsilva

Assignees

@sajauddin sajauddin

@yussufsh yussufsh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@varad-ahirwadkar @Prajyot-Parab @Rajalakshmi-Girish @yussufsh @pravin-dsilva @ppc64le-cloud-bot @sajauddin