Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor enhancement for OCP EUS-EUS upgrade #178

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

varad-ahirwadkar
Copy link

This PR includes enhancements requested in the issue #174

Signed-off-by: Varad Ahirwadkar varad.ahirwadkar@ibm.com

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 23, 2022
@varad-ahirwadkar
Copy link
Author

/cc @pravin-dsilva @yussufsh

@mkumatag mkumatag removed their request for review January 4, 2023 05:19
@yussufsh
Copy link
Contributor

@varad-ahirwadkar please check the review comments.

@varad-ahirwadkar
Copy link
Author

@varad-ahirwadkar please check the review comments.

Sorry for delay, I was working on review comments. I will continue.

…n#174)

Signed-off-by: Varad Ahirwadkar <varad.ahirwadkar@ibm.com>
@yussufsh
Copy link
Contributor

yussufsh commented Feb 3, 2023

/approve
/assign @pravin-dsilva
@varad-ahirwadkar please resolve the conversations which ever are fixed.

@ppc64le-cloud-bot ppc64le-cloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2023
@pravin-dsilva
Copy link
Collaborator

/approve

@ppc64le-cloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pravin-dsilva, varad-ahirwadkar, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yussufsh
Copy link
Contributor

yussufsh commented Feb 3, 2023

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2023
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 9fe3beb into ocp-power-automation:main Feb 3, 2023
@yussufsh yussufsh linked an issue Oct 4, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor enhancement required for OCP EUS-EUS upgrade
4 participants