Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the memory limits for the powervm-rmc pods. #180

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Update the memory limits for the powervm-rmc pods. #180

merged 1 commit into from
Mar 15, 2023

Conversation

kishen-v
Copy link
Contributor

This PR has the updated limits for the powervm-rmc pod which prevents encountering the OOMKilled and subsequent CrashLoopBackOff errors on large compute nodes for the same.

The change was tested on a node of size 64 Cores and 256GB of memory and the desired behaviour of the powervm-rmc pod was observed.

@ppc64le-cloud-bot
Copy link

Welcome @kishen-v! It looks like this is your first PR to ocp-power-automation/ocp4-playbooks 🎉

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 14, 2023
@kishen-v kishen-v force-pushed the update-limits-requests-rmc branch from e6056f9 to dc36f93 Compare March 14, 2023 16:34
@kishen-v
Copy link
Contributor Author

/cc @pravin-dsilva

@kishen-v kishen-v force-pushed the update-limits-requests-rmc branch from dc36f93 to 4968b28 Compare March 14, 2023 16:37
@kishen-v
Update the memory limit for the powervm-rmc pods.
b6eecc5 
Signed-off-by: Kishen V <kishen.viswanathan@ibm.com>
@kishen-v kishen-v force-pushed the update-limits-requests-rmc branch from 4968b28 to b6eecc5 Compare March 14, 2023 16:38
Prajyot-Parab
Prajyot-Parab approved these changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/non-mergeable labels Mar 14, 2023
@yussufsh
Copy link
Contributor

The change was tested on a node of size 64 Cores and 256GB of memory and the desired behaviour of the powervm-rmc pod was observed.

@kishen-v did we test this out with a smaller configuration as well?

@kishen-v
Copy link
Contributor Author

The change was tested on a node of size 64 Cores and 256GB of memory and the desired behaviour of the powervm-rmc pod was observed.

@kishen-v did we test this out with a smaller configuration as well?

Hi @yussufsh, yes. We had initially loaded these limits for the powervm-rmc pod on a node of small compute capacity - (0.5C/32GB), which was then resized to 64C/256GB of memory. OOMKilled error was not observed.

@yussufsh
Copy link
Contributor

/approve

@ppc64le-cloud-bot ppc64le-cloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2023
@ppc64le-cloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishen-v, Prajyot-Parab, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot merged commit b4df5f7 into ocp-power-automation:main Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prajyot-Parab Prajyot-Parab Prajyot-Parab approved these changes

@yussufsh yussufsh yussufsh approved these changes

@sajauddin sajauddin Awaiting requested review from sajauddin

@pravin-dsilva pravin-dsilva Awaiting requested review from pravin-dsilva

Assignees

@Prajyot-Parab Prajyot-Parab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kishen-v @ppc64le-cloud-bot @yussufsh @Prajyot-Parab