Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update branch reference in CONTRIBUTING.md to main #184

Merged
merged 1 commit into from
May 4, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Contributing

This project is [Apache 2.0 Licenced](https://github.com/ocp-power-automation/ocp4-playbooks/blob/master/LICENSE) and welcomes external contributions. When contributing to this repository, please first discuss the change you wish to make via an [issue](https://github.com/ocp-power-automation/ocp4-playbooks/issues).
This project is [Apache 2.0 Licenced](https://github.com/ocp-power-automation/ocp4-playbooks/blob/main/LICENSE) and welcomes external contributions. When contributing to this repository, please first discuss the change you wish to make via an [issue](https://github.com/ocp-power-automation/ocp4-playbooks/issues).

Please note we have a [code of conduct](https://github.com/ocp-power-automation/ocp4-playbooks/blob/master/CODE_OF_CONDUCT.md), please follow it in all your interactions with the project.
Please note we have a [code of conduct](https://github.com/ocp-power-automation/ocp4-playbooks/blob/main/CODE_OF_CONDUCT.md), please follow it in all your interactions with the project.

# Issues

@@ -13,12 +13,12 @@ Please note we have a [code of conduct](https://github.com/ocp-power-automation/
# Pull Request Process

- To contribute code or documentation, please submit a [pull request](https://github.com/ocp-power-automation/ocp4-playbooks/pulls).
- Always take the latest update from upstream/master before creating a pull request.
- Always take the latest update from upstream/main before creating a pull request.
- Ensure your changes work fine and have no syntax problems. Also, verify that it does not break the existing code flow.
- Update the README.md or relevant documents with details of changes to the code. This includes variables change, added or updated feature, change in steps, dependencies change, etc.
- Make use of proper commit message. Mention the issue# which you are planning to address eg: Fixes #38.
- After creating the pull request ensure you implement all the review comments given if any. Pull request will be merged only when it has at least two approvals from the list of reviewers.
- Please read [Developer Certificate of Origin](https://github.com/ocp-power-automation/ocp4-playbooks/blob/master/DCO1.1.txt) and sign-off your commit using command `git commit -s`.
- Please read [Developer Certificate of Origin](https://github.com/ocp-power-automation/ocp4-playbooks/blob/main/DCO1.1.txt) and sign-off your commit using command `git commit -s`.


# Spec Formatting Conventions