This repository has been archived by the owner on Aug 18, 2023. It is now read-only.
Fix dns forwarders in bastion node #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yussufsh
reviewed
Oct 17, 2020
modules/3_helpernode/helpernode.tf
Outdated
| gateway_ip = var.gateway_ip | ||
| netmask = cidrnetmask(var.cidr) | ||
| broadcast = cidrhost(var.cidr,-1) | ||
| ipid = cidrhost(var.cidr, 0) | ||
| pool = var.allocation_pools[0] | ||
| forwarder1 = trimspace(element(local.forwarders, 0)) | ||
| forwarder2 = length(local.forwarders) > 1 ? trimspace(element(local.forwarders, 1)) : "" |
There was a problem hiding this comment.
Can we take care of case when user want to use 3 name servers? I don't mind making the variable var.dns_forwarders as a list.
Secondly, It will be good to use local.forwarders[0] syntax instead of element function.
Thanks.
There was a problem hiding this comment.
Thanks for the comments. I implemented both of your comments.
The dns interface to the ocp4-helpernode project is forwarder1 and forwarder2. Presently, only forwarder1 is specified and the ocp4-helpernode project adds the second forwarder which has a default value of 8.8.4.4. The dns interface to the ocp4-upi-kvm project is a string composed of multiple dns servers, so it needs to be translated into forwarder1 and forwarder2. This is not presently happening. This results in 3 dns servers being defined in the bastion node, including the extra dns server 8.8.4.4 which was not requested. Redhat OCS utilizes NTP servers that are behind the firewall which are frequently not resolved correctly due to the use of dns server 8.8.4.4. The following line appears thousands of times in /var/log/messages. Oct 16 10:31:27 nx144-ahv dnsmasq[36993]: Maximum number of concurrent DNS queries reached (max: 150) The OCS configuration requires that all dns requests be forwarded to the host server which is accomplished by specifying 192.168.88.1 and 127.0.0.1, both of which resolve to the host server. The too many concurrent dns request error message no longer occur with this change. Signed-off-by: Luke Browning <lukebrowning@us.ibm.com>
zmc
pushed a commit
to zmc/ocp4-upi-kvm
that referenced
this pull request
Oct 22, 2020
The dns interface to the ocp4-helpernode project is forwarder1 and forwarder2. Presently, only forwarder1 is specified and the ocp4-helpernode project adds the second forwarder which has a default value of 8.8.4.4. The dns interface to the ocp4-upi-kvm project is a string composed of multiple dns servers, so it needs to be translated into forwarder1 and forwarder2. This is not presently happening. This results in 3 dns servers being defined in the bastion node, including the extra dns server 8.8.4.4 which was not requested. Redhat OCS utilizes NTP servers that are behind the firewall which are frequently not resolved correctly due to the use of dns server 8.8.4.4. The following line appears thousands of times in /var/log/messages. Oct 16 10:31:27 nx144-ahv dnsmasq[36993]: Maximum number of concurrent DNS queries reached (max: 150) The OCS configuration requires that all dns requests be forwarded to the host server which is accomplished by specifying 192.168.88.1 and 127.0.0.1, both of which resolve to the host server. The too many concurrent dns request error message no longer occur with this change. Signed-off-by: Luke Browning <lukebrowning@us.ibm.com> (cherry picked from commit 5eb3b7e)
satwinder0867
pushed a commit
to satwinder0867/ocp4-upi-kvm
that referenced
this pull request
Oct 30, 2020
The dns interface to the ocp4-helpernode project is forwarder1 and forwarder2. Presently, only forwarder1 is specified and the ocp4-helpernode project adds the second forwarder which has a default value of 8.8.4.4. The dns interface to the ocp4-upi-kvm project is a string composed of multiple dns servers, so it needs to be translated into forwarder1 and forwarder2. This is not presently happening. This results in 3 dns servers being defined in the bastion node, including the extra dns server 8.8.4.4 which was not requested. Redhat OCS utilizes NTP servers that are behind the firewall which are frequently not resolved correctly due to the use of dns server 8.8.4.4. The following line appears thousands of times in /var/log/messages. Oct 16 10:31:27 nx144-ahv dnsmasq[36993]: Maximum number of concurrent DNS queries reached (max: 150) The OCS configuration requires that all dns requests be forwarded to the host server which is accomplished by specifying 192.168.88.1 and 127.0.0.1, both of which resolve to the host server. The too many concurrent dns request error message no longer occur with this change. Signed-off-by: Luke Browning <lukebrowning@us.ibm.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dns interface to the ocp4-helpernode project is forwarder1 and
forwarder2. Presently, only forwarder1 is specified and the
ocp4-helpernode project adds the second forwarder which has a
default value of 8.8.4.4.
The dns interface to the ocp4-upi-kvm project is a string composed
of multiple dns servers, so it needs to be translated into forwarder1
and forwarder2. This is not presently happening. This results in
3 dns servers being defined in the bastion node, including the
extra dns server 8.8.4.4 which was not requested.
Redhat OCS utilizes NTP servers that are behind the firewall which are
frequently not resolved correctly due to the use of dns server 8.8.4.4.
The following line appears thousands of times in /var/log/messages.
Oct 16 10:31:27 nx144-ahv dnsmasq[36993]: Maximum number of concurrent DNS queries reached (max: 150)
The OCS configuration requires that all dns requests be forwarded to
the host server which is accomplished by specifying 192.168.88.1 and
127.0.0.1, both of which resolve to the host server.
The too many concurrent dns request error message no longer occur
with this change.
Signed-off-by: Luke Browning lukebrowning@us.ibm.com