Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add availability-zone as optinal attribute for OCP cluster nodes, Fix #179 #178

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

cs-zhang
Copy link
Collaborator

@cs-zhang cs-zhang commented Mar 1, 2021

Fix 179

Add availability_zone as the optional attribute for OCP node : bastion, bootstrap, master and worker. If it is not specified the openstack_availability_zone will be used for them.

Signed-off-by: CS Zhang zhangcho@us.ibm.com

@cs-zhang cs-zhang requested review from bpradipt and yussufsh March 1, 2021 20:14
@ltccci ltccci added the size/M label Mar 1, 2021
docs/var.tfvars-doc.md Outdated Show resolved Hide resolved
docs/var.tfvars-doc.md Outdated Show resolved Hide resolved
var.tfvars Outdated Show resolved Hide resolved
modules/4_nodes/nodes.tf Outdated Show resolved Hide resolved
@yussufsh yussufsh changed the title Enabel availability-zone for OCP cluster nodes. Enable availability-zone for OCP cluster nodes. Mar 3, 2021
@yussufsh
Copy link
Contributor

yussufsh commented Mar 3, 2021

@cs-zhang Please correct the typo in commit message and better describe the problem you are trying to fix in an issue.

@cs-zhang cs-zhang changed the title Enable availability-zone for OCP cluster nodes. Add availability-zone as optinal attribute for OCP cluster nodes Mar 3, 2021
Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

docs/var.tfvars-doc.md Outdated Show resolved Hide resolved
@ltccci ltccci removed the lgtm label Mar 4, 2021
@cs-zhang cs-zhang changed the title Add availability-zone as optinal attribute for OCP cluster nodes Add availability-zone as optinal attribute for OCP cluster nodes, Fix 179 Mar 5, 2021
@cs-zhang cs-zhang changed the title Add availability-zone as optinal attribute for OCP cluster nodes, Fix 179 Add availability-zone as optinal attribute for OCP cluster nodes, Fix #179 Mar 5, 2021
Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ltccci
Copy link
Contributor

ltccci commented Mar 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpradipt, cs-zhang, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ltccci ltccci merged commit 4a92578 into ocp-power-automation:master Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants