-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default CNI to OVNKubernetes #257
Update default CNI to OVNKubernetes #257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
We need to set this default option only for the 4.12+ versions, any idea how do we handle that ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
@pravin-dsilva: PR is not mergeable. The PR state is: BLOCKED Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve We are going to share variable file for each version and ask user to use a particular file while installing a required OCP version. The default variables will only support latest stable release.
The docs need to change to show how to run the terraform command, |
Signed-off-by: Pravin D'silva <pravin.dsilva@ibm.com>
dbbd54b
to
0487742
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Prajyot-Parab, pravin-dsilva, yussufsh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
With OCP 4.12, the default network type is OVNKubernetes
Reference: openshift/installer#6014
Signed-off-by: Pravin D'silva pravin.dsilva@ibm.com