Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UUID in fstab for nfs export FS for stability after reboot. #260

Merged

Conversation

schabrolles
Copy link
Contributor

@schabrolles schabrolles commented Dec 1, 2022

link /dev/disk/pv-storage-disk points to a /dev/dm-* when using multipathed disk.
This dm- device can be renumbered after a reboot, which could prevent the bastion/helpernode to reboot properly (maintenance mode because /export cannot be mount).

The best way is to get the UUID generated after the creation of the FS and use this one in the fstab.

@ppc64le-cloud-bot
Copy link

Hi @schabrolles. Thanks for your PR.

I'm waiting for a ocp-power-automation member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Sebastien Chabrolles <s.chabrolles@fr.ibm.com>
@schabrolles
Copy link
Contributor Author

schabrolles commented Dec 13, 2022

Can you have a look on this one ?

If your bastion boot on san with multipath, having a exportfs can prevent the linux to reboot properly.

/assign @cs-zhang

@schabrolles
Copy link
Contributor Author

/assign @cs-zhang

Copy link
Collaborator

@cs-zhang cs-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@schabrolles
Copy link
Contributor Author

/assign @sajauddin

@schabrolles
Copy link
Contributor Author

/assign @yussufsh
/assign @Prajyot-Parab

@schabrolles
Copy link
Contributor Author

@sajauddin could you please have a look on this one.

Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
@schabrolles could you please check if we can do the same with powervs automation?

@ppc64le-cloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cs-zhang, schabrolles, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 4bd1968 into ocp-power-automation:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants