Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPENSHIFTP-168: add fips enablement for 4.16 and higher #285

Merged
merged 1 commit into from
Jul 23, 2024
Merged

OPENSHIFTP-168: add fips enablement for 4.16 and higher #285

merged 1 commit into from
Jul 23, 2024

Conversation

prb112
Copy link
Contributor

@prb112 prb112 commented Jul 12, 2024 •
edited
Loading

yussufsh
yussufsh requested changes Jul 14, 2024
View reviewed changes
Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the fmt errors.

modules/1_bastion/versions.tf Outdated Show resolved Hide resolved
modules/1_bastion/bastion.tf Outdated Show resolved Hide resolved
@prb112
Copy link
Contributor Author

prb112 commented Jul 17, 2024

320 is merged.

@yussufsh
Copy link
Contributor

320 is merged.

@prb112 we need to update https://github.com/ocp-power-automation/ocp4-upi-powervm/blob/main/variables.tf#L278 hash to pull the new helpernode changes.

@prb112
OPENSHIFTP-168: add fips enablement for 4.16 and higher
111495a 
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112
Copy link
Contributor Author

prb112 commented Jul 23, 2024

320 is merged.

@prb112 we need to update https://github.com/ocp-power-automation/ocp4-upi-powervm/blob/main/variables.tf#L278 hash to pull the new helpernode changes.

Hey Yussuf,

Thank you, I had it manually overriden in my local. It is now updated.

Paul

yussufsh
yussufsh approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prb112, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 24f960f into ocp-power-automation:main Jul 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yussufsh yussufsh yussufsh approved these changes

@Prajyot-Parab Prajyot-Parab Awaiting requested review from Prajyot-Parab

@sudeeshjohn sudeeshjohn Awaiting requested review from sudeeshjohn

Assignees

@yussufsh yussufsh

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prb112 @yussufsh @ppc64le-cloud-bot