Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helpernode and ocp4-playbooks tags for latest code #97

Closed

Conversation

Prajyot-Parab
Copy link
Collaborator

Fixes: #96
Signed-off-by: Prajyot Parab prajyot.parab@ibm.com

Fixes: ocp-power-automation#96
Signed-off-by: Prajyot Parab <prajyot.parab@ibm.com>
@yussufsh
Copy link
Contributor

@Prajyot-Parab Did you test this?
Specially https://github.com/RedHatOfficial/ocp4-helpernode/blob/master/vars/main.yml#L11 is required. In my experience, this will download x86 version and fail during extraction

@yussufsh
Copy link
Contributor

We either wait for redhat-cop/ocp4-helpernode#140 OR provide ppc64le url in helpernode_vars.yaml.

@Prajyot-Parab
Copy link
Collaborator Author

Yes @yussufsh this would fail because of helm_source. Thanks for pointing it out.
I am fine with waiting for that PR to get merged or going ahead and doing changes related to setting helm_source.

@mkumatag mkumatag closed this Aug 14, 2020
@mkumatag
Copy link
Member

reopening to run the terraform validate job

@ltccci
Copy link
Contributor

ltccci commented Aug 14, 2020

Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

  • 6c9a5eb Update helpernode and ocp4-playbooks tags for latest code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ltccci ltccci added the size/XS label Aug 14, 2020
@yussufsh
Copy link
Contributor

@Prajyot-Parab are we good to update this? Can you follow up with Christian on helpernode changes to ignore helm binary?

If that is taking more time then better add helm ppc link?

@yussufsh yussufsh closed this Sep 18, 2020
@yussufsh
Copy link
Contributor

Closed by mistake. Re-opening...

@yussufsh yussufsh reopened this Sep 18, 2020
@ltccci
Copy link
Contributor

ltccci commented Sep 18, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Prajyot-Parab
To complete the pull request process, please assign bpradipt
You can assign the PR to them by writing /assign @bpradipt in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ltccci
Copy link
Contributor

ltccci commented Sep 18, 2020

@Prajyot-Parab: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-ocp4-upi-powervm-terraform-validate 6c9a5eb link /test pull-ocp4-upi-powervm-terraform-validate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Prajyot-Parab
Copy link
Collaborator Author

Closing this one as no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update helper node tag
4 participants