Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor_attributes missing Group in Incident Finding #1318

Open
pagbabian-splunk opened this issue Jan 15, 2025 · 0 comments
Open

vendor_attributes missing Group in Incident Finding #1318

pagbabian-splunk opened this issue Jan 15, 2025 · 0 comments
Assignees
@floydtree
Labels
bug Something isn't working v1.4.0 Changes marked for the upcoming version 1.4.0

Comments

@pagbabian-splunk
Copy link
Contributor

The vendor_attributes attribute should have a Group: either Primary, Context.
@pagbabian-splunk pagbabian-splunk added bug Something isn't working v1.4.0 Changes marked for the upcoming version 1.4.0 labels Jan 15, 2025
@floydtree floydtree mentioned this issue Jan 21, 2025
Merged
@floydtree floydtree self-assigned this Jan 21, 2025
davemcatcisco pushed a commit that referenced this issue Jan 22, 2025
@floydtree
Bugfix, adding group prop for vendor_attributes (#1321)
d4bb784 
#### Related Issue: #1318

Minor addition, adding `group` property to `vendor_attributes`
definition in the base finding class. No changes necessary to the
Changelog

Signed-off-by: Rajas Panat <rajaspa@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@floydtree floydtree

Labels
bug Something isn't working v1.4.0 Changes marked for the upcoming version 1.4.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pagbabian-splunk @floydtree