Fixed patch_state profile construction; Removed requirement overrides from _resource. #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from _resource (name, uid) - should not be optional if in a constraint. Signed-off-by: Paul Agbabian <pagbabian@splunk.com>
pagbabian-splunk
requested review from
floydtree,
Aniak5,
mikeradka and
zschmerber
as code owners
Signed-off-by: Paul Agbabian <pagbabian@splunk.com>
pagbabian-splunk
added
bug
floydtree
approved these changes
May 16, 2024
mikeradka
approved these changes
May 16, 2024
zschmerber
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #1086, #1075
Description of changes:
Attributes in a constraint should be recommended, not optional.
_resourcewas overriding the_entityrequirements to optional. This bug fix removes the override.The
patch_stateDiscovery event class was registered with theHostprofile, but not including theprofiles/host.jsonattributes. The built-indeviceattribute needed a"profile": nullstatement in its clause.