Skip to content

Add Email Account type_id and Forwarding Address Support #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2024
Merged

Add Email Account type_id and Forwarding Address Support #1179

merged 2 commits into from
Sep 18, 2024

Conversation

mikeradka
Copy link
Contributor

Related Issue: N/A

Description of changes:

It is quite common for a user to set a forwarding address for their email account.

This PR adds:

  • An Email Account enum as a type_id in the account object.
  • A forward_addr attribute to the dictionary and user object.
image image image

@mikeradka
Add forward_addr
07da776 
Signed-off-by: Michael Radka <mradka@splunk.com>
@mikeradka mikeradka added enhancement New feature or request non_breaking Non Breaking, backwards compatible changes v1.4.0 Changes marked for the upcoming version 1.4.0 labels Sep 18, 2024
@mikeradka mikeradka self-assigned this Sep 18, 2024
@mikeradka
Add PR no to CHANGELOG
376c42d 
Signed-off-by: Michael Radka <mradka@splunk.com>
jonrau-at-queryai
jonrau-at-queryai approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@jonrau-at-queryai jonrau-at-queryai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, I like this! Good stuff 🚢

Aniak5
Aniak5 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@Aniak5 Aniak5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Aniak5 Aniak5 merged commit f2d5eb2 into ocsf:main Sep 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aniak5 Aniak5 Aniak5 approved these changes

@floydtree floydtree floydtree approved these changes

@jonrau-at-queryai jonrau-at-queryai jonrau-at-queryai approved these changes

@rmouritzen-splunk rmouritzen-splunk Awaiting requested review from rmouritzen-splunk

@pagbabian-splunk pagbabian-splunk Awaiting requested review from pagbabian-splunk pagbabian-splunk is a code owner

@zschmerber zschmerber Awaiting requested review from zschmerber zschmerber is a code owner

Assignees

@mikeradka mikeradka

Labels
enhancement New feature or request non_breaking Non Breaking, backwards compatible changes v1.4.0 Changes marked for the upcoming version 1.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikeradka @Aniak5 @floydtree @jonrau-at-queryai