Adding a Tags - key:value pair object to the schema #1207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rajas Panat <rajaspa@amazon.com>
Signed-off-by: Rajas Panat <rajaspa@amazon.com>
Signed-off-by: Rajas Panat <rajaspa@amazon.com>
Signed-off-by: Rajas Panat <rajaspa@amazon.com>
floydtree
added
enhancement
Signed-off-by: Rajas Panat <rajaspa@amazon.com>
floydtree
requested review from
pagbabian-splunk,
Aniak5,
mikeradka and
zschmerber
as code owners
jonrau-at-queryai
approved these changes
Oct 16, 2024
zschmerber
approved these changes
Oct 17, 2024
I like your enthusiasm. If you notice, all the AWS mappings are versioned, we'll update it as we release the mappings for the next stable release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: From Oct 16th, 2024 Network Activity Call.
Currently, we have
labels, a string array attribute that can be used to populate labels. A String array is not sufficient when labels come in the formkey:valuepairs. Therefore, adding a tag object which can allow users to populate key:value styled labels/tags in the events.Description of changes:
tagobject, addingtagsto dictionary.tagattribute, captionedImage Tag(was used in Image and Container) adding labels and tags to the object as alternatives and for consistency.tagsto all the objects where,labelsis currently used. And sorting the file contents.