-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add TLS to evidences #1244
Merged
Merged
add TLS to evidences #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zschmerber
requested review from
floydtree,
pagbabian-splunk,
Aniak5,
mikeradka,
jonrau-at-queryai and
davemcatcisco
as code owners
November 7, 2024 20:26
zschmerber
added
v1.4.0 or later
Changes marked for versions beyond v1.3.0 of OCSF
enhancement
New feature or request
labels
Nov 7, 2024
jonrau-at-queryai
previously approved these changes
Nov 12, 2024
Aniak5
reviewed
Nov 12, 2024
Aniak5
reviewed
Nov 12, 2024
irakledibm
reviewed
Nov 12, 2024
Aniak5
previously approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mikeradka
previously approved these changes
Nov 19, 2024
pagbabian-splunk
previously approved these changes
Nov 25, 2024
Signed-off-by: Paul Agbabian <pagbabian@splunk.com>
pagbabian-splunk
dismissed stale reviews from mikeradka, Aniak5, and themself
via
November 25, 2024 21:58
85da295
Aniak5
approved these changes
Nov 26, 2024
irakledibm
approved these changes
Nov 26, 2024
floydtree
approved these changes
Nov 26, 2024
jonrau-at-queryai
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
v1.4.0 or later
Changes marked for versions beyond v1.3.0 of OCSF
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds TLS and ja4+ objects to the evidences object