Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RFC 5322 to email attribute references #1256

Merged
merged 13 commits into from
Nov 22, 2024
Merged

Add RFC 5322 to email attribute references #1256

merged 13 commits into from
Nov 22, 2024

Conversation

mikeradka
Copy link
Contributor

@mikeradka mikeradka commented Nov 19, 2024 •
edited
Loading

Related Issue:

N/A

Description of changes:

This PR adds a reference for all RFC 5322 attributes.

Example:

image

Note: since this is a metaschema attribute update, no need to update CHANGELOG.

@mikeradka mikeradka self-assigned this Nov 19, 2024
@mikeradka mikeradka added enhancement New feature or request non_breaking Non Breaking, backwards compatible changes labels Nov 19, 2024
Aniak5
Aniak5 previously approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@Aniak5 Aniak5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mikeradka mikeradka marked this pull request as draft November 19, 2024 21:29
@mikeradka mikeradka changed the title Add RFC 5322 Link to descriptions DRAFT: Add RFC 5322 Link to descriptions Nov 19, 2024
@mikeradka
Add RFC 5322 to References
9577a53 
Signed-off-by: Michael Radka <mradka@splunk.com>
@mikeradka mikeradka marked this pull request as ready for review November 20, 2024 22:11
@mikeradka mikeradka changed the title DRAFT: Add RFC 5322 Link to descriptions Add RFC 5322 to email attribute references Nov 20, 2024
davemcatcisco
davemcatcisco reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@davemcatcisco davemcatcisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update CHANGELOG.md.

@mikeradka
Copy link
Contributor Author

Don't forget to update CHANGELOG.md.

Great observation! Typically, we refrain from updating the CHANGELOG for description updates and references to maintain its conciseness. @floydtree, would you agree with this approach?

@floydtree
Copy link
Contributor

Great observation! Typically, we refrain from updating the CHANGELOG for description updates and references to maintain its conciseness. @floydtree, would you agree with this approach?

Yep, since we are only refining a description/adding a reference in this case, I don't think we need a Changelog entry for it.

@davemcatcisco
Copy link
Contributor

Great observation! Typically, we refrain from updating the CHANGELOG for description updates and references to maintain its conciseness. @floydtree, would you agree with this approach?

Yep, since we are only refining a description/adding a reference in this case, I don't think we need a Changelog entry for it.

Good to know. Thanks, guys.

@davemcatcisco davemcatcisco merged commit 1e8d2b2 into ocsf:main Nov 22, 2024
3 checks passed
@mikeradka mikeradka deleted the Add_RFC_5322_Link branch November 22, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davemcatcisco davemcatcisco davemcatcisco approved these changes

@floydtree floydtree floydtree approved these changes

@Aniak5 Aniak5 Aniak5 approved these changes

@pagbabian-splunk pagbabian-splunk Awaiting requested review from pagbabian-splunk pagbabian-splunk is a code owner

@zschmerber zschmerber Awaiting requested review from zschmerber zschmerber is a code owner

@jonrau-at-queryai jonrau-at-queryai Awaiting requested review from jonrau-at-queryai jonrau-at-queryai is a code owner

Assignees

@mikeradka mikeradka

Labels
enhancement New feature or request non_breaking Non Breaking, backwards compatible changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikeradka @floydtree @davemcatcisco @Aniak5