-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SBOM support to Software Inventory Info event class #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sherif Clinch <sheriff129@protonmail.com>
This reverts commit b5bf179.
Signed-off-by: Sherif Clinch <sheriff129@protonmail.com>
SherifSec
requested review from
floydtree,
pagbabian-splunk,
Aniak5,
mikeradka,
zschmerber,
jonrau-at-queryai and
davemcatcisco
as code owners
November 22, 2024 17:12
Signed-off-by: Sherif Clinch <sheriff129@protonmail.com>
Signed-off-by: Sherif Clinch <sheriff129@protonmail.com>
jonrau-at-queryai
previously approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hate SBOMs 🤣 but this is a really good representation of them.
mikeradka
previously approved these changes
Dec 3, 2024
Signed-off-by: SherifSec <sheriff129@protonmail.com>
SherifSec
dismissed stale reviews from mikeradka and jonrau-at-queryai
via
December 4, 2024 11:23
02c01b4
jonrau-at-queryai
approved these changes
Dec 4, 2024
mikeradka
approved these changes
Dec 4, 2024
zschmerber
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: N/A
Description of changes:
Updates the Software Inventory Info event class to enable attaching an SBOM. I wanted to start simple for now by representing one type of relationship which is "depends on" used in both SPDX and CycloneDX. This will allow users to map direct and transitive relationships expressed in SBOMs.
Also per the NTIA, I wanted to make sure the minimum data fields of an SBOM were included.
Ran locally on the OCSF server and confirmed working.