Update the Security Control action_id enumeration #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Agbabian <pagbabian@splunk.com>
…iption examples. Also corrected the profile description where is_detection was referenced vs. is_alert. Signed-off-by: Paul Agbabian <pagbabian@splunk.com>
pagbabian-splunk
requested review from
floydtree,
Aniak5,
mikeradka,
zschmerber,
jonrau-at-queryai and
davemcatcisco
as code owners
Signed-off-by: Paul Agbabian <pagbabian@splunk.com>
davemcatcisco
approved these changes
Nov 25, 2024
zschmerber
approved these changes
Nov 25, 2024
floydtree
approved these changes
Nov 25, 2024
pagbabian-splunk
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: Slack discussion 11/25/2024
Description of changes:
Security Control had been modified to add a required
action_idwith only two values,AllowedandDenied.This PR adds Observed and Modified for cases where the control or monitor doesn't explicitly allow or deny but observes and reports or in some cases modified the activity.
Also corrected a previous error in the profile's description and added the standard
Otherenum that was omitted, possibly on purpose.