Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More d3fend references for objects (based on PR 1173) #1267

Merged
merged 15 commits into from
Dec 3, 2024
Merged

Conversation

pagbabian-splunk
Copy link
Contributor

@pagbabian-splunk pagbabian-splunk commented Nov 25, 2024

Related PR: 1173 (should be closed in lieu of new approach for linked references)

Description of changes:

Added references[] meta data for MITRE d3fend artifacts:

  1. win/reg_key
  2. win/reg_value
  3. account
  4. container
  5. database
  6. fingerprint
  7. group
  8. http_cookie
  9. job
  10. script

floydtree
floydtree previously approved these changes Nov 26, 2024
mikeradka
mikeradka previously approved these changes Nov 27, 2024
floydtree and others added 2 commits November 27, 2024 11:01
Signed-off-by: Jonathan Rau <139361268+jonrau-at-queryai@users.noreply.github.com>
@jonrau-at-queryai jonrau-at-queryai dismissed stale reviews from mikeradka and floydtree via 9e8d650 December 3, 2024 17:16
@floydtree floydtree requested a review from mikeradka December 3, 2024 18:15
floydtree
floydtree previously approved these changes Dec 3, 2024
mikeradka
mikeradka previously approved these changes Dec 3, 2024
Copy link
Contributor

@mikeradka mikeradka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One nit is a consideration of whether we want these stanzas to be block rather than single line. But it would be purely for readability so I am still approving.

Signed-off-by: Jonathan Rau <139361268+jonrau-at-queryai@users.noreply.github.com>
@jonrau-at-queryai jonrau-at-queryai dismissed stale reviews from mikeradka and themself via d920f2d December 3, 2024 20:43
@mikeradka mikeradka self-requested a review December 3, 2024 20:46
Signed-off-by: Michael Radka <mradka@splunk.com>
@floydtree floydtree merged commit 9349965 into main Dec 3, 2024
3 checks passed
@floydtree floydtree deleted the more_d3fend branch December 3, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants