-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More d3fend references for objects (based on PR 1173) #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Agbabian <pagbabian@splunk.com>
… PR #1173 doing it the old way via descriptions. Signed-off-by: Paul Agbabian <pagbabian@splunk.com>
pagbabian-splunk
requested review from
floydtree,
Aniak5,
mikeradka,
zschmerber,
jonrau-at-queryai and
davemcatcisco
as code owners
November 25, 2024 22:48
floydtree
previously approved these changes
Nov 26, 2024
mikeradka
previously approved these changes
Nov 27, 2024
Signed-off-by: Jonathan Rau <139361268+jonrau-at-queryai@users.noreply.github.com>
jonrau-at-queryai
dismissed stale reviews from mikeradka and floydtree
via
December 3, 2024 17:16
9e8d650
floydtree
previously approved these changes
Dec 3, 2024
mikeradka
previously approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One nit is a consideration of whether we want these stanzas to be block rather than single line. But it would be purely for readability so I am still approving.
jonrau-at-queryai
previously approved these changes
Dec 3, 2024
Signed-off-by: Jonathan Rau <139361268+jonrau-at-queryai@users.noreply.github.com>
jonrau-at-queryai
dismissed stale reviews from mikeradka and themself
via
December 3, 2024 20:43
d920f2d
jonrau-at-queryai
previously approved these changes
Dec 3, 2024
Signed-off-by: Michael Radka <mradka@splunk.com>
mikeradka
approved these changes
Dec 3, 2024
jonrau-at-queryai
approved these changes
Dec 3, 2024
floydtree
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: 1173 (should be closed in lieu of new approach for linked references)
Description of changes:
Added references[] meta data for MITRE d3fend artifacts: