Add common device identifier fields to aid unique identification of Linux, Mac and Windows computers

[antchan2]

Related Issue:

#1248

Description of changes:

This change adds two optional identifier fields to the Device object to aid combining telemetry for the same device from multiple sources :

1. os_machine_uuid:

2. device_hw_info.uuid

[jonrau-at-queryai]

Could we remove the win and nix specific attributes out of the extension and just make them part of core os? We already have OS-specific attributes there after all

[pagbabian-splunk]

Could we remove the win and nix specific attributes out of the extension and just make them part of core os? We already have OS-specific attributes there after all

The way I would suggest we do this: given that both machine identifiers are of type uuid_t I would just add one attribute, to device, machine_uuid (or machine_uid but NOT machine_id which we reserve for enums). In the description we can have both examples of where they are found, i.e. one for linux and one for Windows. Alternatively, these may be OS instance IDs, in which case we might consider that the machine_uuid is added to OS. Of course, the line is blurred in device.

[antchan2]

Thanks for the feedback, @jonrau-at-queryai, @pagbabian-splunk.

In commit 778e083, I consolidated the separate Windows and Linux Machine ID fields into a single device.os_machine_uuid field. This avoids extensions. I believe this field is a better fit in the device object than in os because while the value is assigned by the operating system, it describes the device and not the OS. I added an os_ prefix to the field name to more clearly communicate it is for the OS-assigned value, so one should also consult the os field for proper interpretation.

Let me know if this fully addresses your concerns.