Simplify environment variable object for more compact data representation; removes truncation indicator

[antchan2]

Related Issue:

Fixes ocsf-schema#1272

Description of changes:

Simplify data representation for environment variables array by changing the type of name and value from long_string to string. This removes truncation indicators from those fields but this is a worthwhile trade-off to vastly simplify the general case since truncation is a rare occurrence. environment_variable remains a separate class (i.e., not reuse the Key:Value object) so it can be extended to more elegantly handle truncation, if there turns out to be a real need, in the future.

[mlmitch]

I like it

[zschmerber]

LGTM

[floydtree]

Do we wanna remove the long_string object as well? We can add it down the road if needed. Or do folks see value in it? @mikeradka @zschmerber @davemcatcisco

[mikeradka]

Do we wanna remove the long_string object as well? We can add it down the road if needed. Or do folks see value in it? @mikeradka @zschmerber @davemcatcisco

Hm, good point. I am sure there could be potential down the road for this object, but as of this PR this object would be unreferenced. I suppose since this is merged now, we could either do a subsequent PR to remove this object, or keep the unreferenced object. Maybe in the spirit of keeping the schema clean, we do a follow up PR to remove the long_string objects. Thoughts @davemcatcisco @floydtree @zschmerber ?

[antchan2]

long_string is still used for script content

[mikeradka]

long_string is still used for script content

Ah, good eye. I think that answers that!

[floydtree]

@antchan2 Ah, good catch! Thanks.

[davemcatcisco]

Yes, script content was the original reason for adding it, I think.