-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Actor description to distinguish from a campaign threat actor #1290
Open
pagbabian-splunk
wants to merge
13
commits into
main
Choose a base branch
from
actor_desc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Agbabian <pagbabian@splunk.com>
… to clarify that it isn't a threat actor from a campaign. Signed-off-by: Paul Agbabian <pagbabian@splunk.com>
pagbabian-splunk
requested review from
floydtree,
Aniak5,
mikeradka,
zschmerber,
jonrau-at-queryai and
davemcatcisco
as code owners
December 18, 2024 19:21
mikeradka
added
enhancement
New feature or request
grammar_consistency
Issues related to the attribute grammar consistency work-stream
v1.4.0 or later
Changes marked for versions beyond v1.3.0 of OCSF
labels
Dec 18, 2024
A note here since it came up in discussion, per @jonrau-at-queryai, as far as OSINT is concerned when we get to 1.5.0-dev we will start work on some generic attribution/campaign object. Also per @pagbabian-splunk , if we update OSINT in 1.5.0-dev, we would want to be explicit (e.g. threat_actor campaign_actor) |
jonrau-at-queryai
approved these changes
Dec 18, 2024
pagbabian-splunk
added
description_updates
Issues related to missing/incorrect/lacking descriptions of attributes
and removed
enhancement
New feature or request
grammar_consistency
Issues related to the attribute grammar consistency work-stream
labels
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
description_updates
Issues related to missing/incorrect/lacking descriptions of attributes
v1.4.0 or later
Changes marked for versions beyond v1.3.0 of OCSF
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: N/A (Slack discussion)
Description of changes:
There was a discussion in Slack that called out some new OCSF users being confused by
actor
thinking it is a threat actor, i.e. from a campaign. Althoughactor
might be a vehicle for a threat actor, the descriptions in the dictionary and the object add a sentence making the distinction.