Issue #1294: Add a generic event class for each category #1295
+15
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
#1294
Description of changes:
A generic event class for each category is helpful when mapping existing event logs to OCSF in situations where the category of an event is clear but the work to fully map events is not yet complete.
The alternative is loss of fidelity or just dropping the raw event (not mapping it at all while running in production), neither of which is desirable. The loss of fidelity arises from the use of the Base Event class instead of a generic category-specific class, and thus losing both the category and activity IDs for the generic class.
There should be a warning in the event class descriptions of these generic classes saying exactly why they exist, and steering people away from their use a final solution. The same warning should be added to Base Event.
Delete once you have confirmed the following:
Unreleased
section in the CHANGELOG.md file?TBD