Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 826 Fix: Add activity_id descriptions to Network File Activity #827

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

mikeradka
Copy link
Contributor

Related Issue: #826

Description of changes:

Add descriptions for the Network File Activity activity_id's.
Before (the descriptions were not overridden from the Network File Activity class):
image

After (the descriptions are present an override the generic descriptions:
image

Signed-off-by: Michael Radka <mradka@splunk.com>
@mikeradka mikeradka self-assigned this Oct 18, 2023
@mikeradka mikeradka added enhancement New feature or request network_activity Issues related to Network Activity Category grammar_consistency Issues related to the attribute grammar consistency work-stream labels Oct 18, 2023
@mikeradka mikeradka changed the title Issue 826 Fix: Add activity_id descriptions Issue 826 Fix: Add activity_id descriptions to Network File Activity Oct 18, 2023
Copy link
Contributor

@Aniak5 Aniak5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@floydtree floydtree merged commit cfdf0e1 into ocsf:main Oct 18, 2023
@pagbabian-splunk pagbabian-splunk added the v1.1.0 Changes marked for v1.1.0 of OCSF label Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request grammar_consistency Issues related to the attribute grammar consistency work-stream network_activity Issues related to Network Activity Category v1.1.0 Changes marked for v1.1.0 of OCSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants