Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix whitespace issues in the CVSS object #832

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

ronaldtse
Copy link
Contributor

Related Issue:

None.

Description of changes:

The objects/cvss.json object contains description that misses a whitespace but an additional whitespace within the <code> block.

The {{ pattern in the example within the current description string also causes confusion with readers that it is related to templating syntaxes such as handlebars or liquid.

Signed-off-by: Ronald Tse <ronald.tse@ribose.com>
@taddhar
Copy link

taddhar commented Oct 27, 2023

Well spotted Ron, I support this one.

Copy link
Contributor

@floydtree floydtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for the PR.

@floydtree floydtree added findings Issues related to Findings Category non_breaking Non Breaking, backwards compatible changes labels Oct 27, 2023
@floydtree floydtree merged commit 3729d8e into ocsf:main Oct 27, 2023
@ronaldtse
Copy link
Contributor Author

Thank you @taddhar @floydtree @irakledibm and @mikeradka !

@ronaldtse ronaldtse deleted the rt-escape-double-curly-braces branch October 30, 2023 06:56
@taddhar
Copy link

taddhar commented Oct 30, 2023

Fantastic! I was busy already with calls and will return to this in the coming 2 hours.

@pagbabian-splunk pagbabian-splunk added description_updates Issues related to missing/incorrect/lacking descriptions of attributes v1.1.0 Changes marked for v1.1.0 of OCSF labels Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
description_updates Issues related to missing/incorrect/lacking descriptions of attributes findings Issues related to Findings Category non_breaking Non Breaking, backwards compatible changes v1.1.0 Changes marked for v1.1.0 of OCSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants