-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] New Load Balancer object for HTTP Activity 4002 #861
Conversation
Please provide any thoughts on the attribute names and the descriptions! |
objects/endpoint_responses.json
Outdated
@@ -0,0 +1,26 @@ | |||
{ | |||
"caption": "Endpoint Responses", | |||
"name": "endpoint_responses", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably alter this to be a singular object with Endpoint Response
/ endpoint_response
. With a singular code
and a singular endpoint
. In the dictionary we will leave the endpoint_responses
and set "is_array": true
dictionary.json
Outdated
"is_array": true, | ||
"type": "endpoint" | ||
}, | ||
"endpoint_responses": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should consider renaming this to something that conveys that these are additional connection attempts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per todays conversation endpoint_connections
dictionary.json
Outdated
}, | ||
"endpoint_responses": { | ||
"caption": "Endpoint Responses", | ||
"description": "The Endpoint Responses attribute captures additional information about connection attempts to multiple endpoints", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a .
at the end of this description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And per our conversation, make the description generic so something like "Connection attempts and their responses. See specific usage." And then within the load balancer object make the description specific to the load balancer.
dictionary.json
Outdated
"caption": "Endpoints", | ||
"description": "The Endpoint/s related to the entity.", | ||
"is_array": true, | ||
"type": "endpoint" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per our conversation today change this to be of type network_endpoint
Related Issue: Discussion 846
Description of changes:
Load Balancer
object that contains specific Load Balancer related information and added that object as an optional attribute inHTTP Activity 4002
Endpoint Responses
object that sits as an attribute inside of theLoad Balancer
objectendpoints
attribute that is an array ofEndpoint
objects