Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] New Load Balancer object for HTTP Activity 4002 #861

Closed
wants to merge 0 commits into from

Conversation

nathanbvail
Copy link
Contributor

Related Issue: Discussion 846

Description of changes:

  • Created a new Load Balancer object that contains specific Load Balancer related information and added that object as an optional attribute in HTTP Activity 4002
  • Created a new Endpoint Responses object that sits as an attribute inside of the Load Balancer object
  • Created a new endpoints attribute that is an array of Endpoint objects
  • Lastly, updated the dictionary with the necessary additions.

@nathanbvail
Copy link
Contributor Author

Please provide any thoughts on the attribute names and the descriptions!

@nathanbvail nathanbvail changed the title Draft: New Load Balancer object inside HTTP Activity 4002 [Draft] New Load Balancer object inside HTTP Activity 4002 Nov 20, 2023
@nathanbvail nathanbvail changed the title [Draft] New Load Balancer object inside HTTP Activity 4002 [Draft] New Load Balancer object for HTTP Activity 4002 Nov 20, 2023
@Aniak5 Aniak5 added network_activity Issues related to Network Activity Category non_breaking Non Breaking, backwards compatible changes labels Nov 21, 2023
@nathanbvail
Copy link
Contributor Author

Adding in screenshots for any visual reviewers.
OCSF LB Endpoints
OCSF LB

@@ -0,0 +1,26 @@
{
"caption": "Endpoint Responses",
"name": "endpoint_responses",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably alter this to be a singular object with Endpoint Response / endpoint_response. With a singular code and a singular endpoint. In the dictionary we will leave the endpoint_responses and set "is_array": true

dictionary.json Outdated
"is_array": true,
"type": "endpoint"
},
"endpoint_responses": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should consider renaming this to something that conveys that these are additional connection attempts.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per todays conversation endpoint_connections

dictionary.json Outdated
},
"endpoint_responses": {
"caption": "Endpoint Responses",
"description": "The Endpoint Responses attribute captures additional information about connection attempts to multiple endpoints",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a . at the end of this description.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And per our conversation, make the description generic so something like "Connection attempts and their responses. See specific usage." And then within the load balancer object make the description specific to the load balancer.

dictionary.json Outdated
"caption": "Endpoints",
"description": "The Endpoint/s related to the entity.",
"is_array": true,
"type": "endpoint"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per our conversation today change this to be of type network_endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
network_activity Issues related to Network Activity Category non_breaking Non Breaking, backwards compatible changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants