Make number representations compatible with Wasm #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhugo
reviewed
Jul 29, 2024
hhugo
reviewed
Jul 29, 2024
hhugo
reviewed
Jul 29, 2024
hhugo
reviewed
Jul 29, 2024
hhugo
reviewed
Jul 29, 2024
This was referenced Jul 29, 2024
Merged
OlivierNicole
force-pushed
the
converge-jsoo-tip-02
branch
2 times, most recently
from
4154cf1
to
f2942e4
Compare
hhugo
reviewed
Jul 31, 2024
OlivierNicole
force-pushed
the
converge-jsoo-tip-02
branch
from
f2942e4
to
dd11e23
Compare
hhugo
reviewed
Aug 26, 2024
hhugo
reviewed
Aug 26, 2024
hhugo
reviewed
Aug 26, 2024
hhugo
reviewed
Aug 26, 2024
OlivierNicole
force-pushed
the
converge-jsoo-tip-02
branch
from
9ca2cc0
to
fab177e
Compare
|
Thanks. Looks good. |
OlivierNicole
force-pushed
the
converge-jsoo-tip-02
branch
from
fab177e
to
2b4f30e
Compare
|
Done. It looks like the failing test will only work if I integrate the single commit from #1650, which redefines This may break programs that do not perform explicit float conversions yet. |
Co-authored-by: Olivier Nicole <olivier@chnik.fr>
hhugo
force-pushed
the
converge-jsoo-tip-02
branch
from
2b4f30e
to
256b031
Compare
I removed the last commit, and fixed the hypertree example to use number_t |
|
Thank you |
OlivierNicole
added a commit
to ocaml-wasm/wasm_of_ocaml
that referenced
this pull request
Sep 3, 2024
OlivierNicole
added a commit
to ocaml-wasm/wasm_of_ocaml
that referenced
this pull request
Sep 3, 2024
OlivierNicole
added a commit
to ocaml-wasm/wasm_of_ocaml
that referenced
this pull request
Sep 9, 2024
OlivierNicole
added a commit
to OlivierNicole/wasm_of_ocaml
that referenced
this pull request
Sep 9, 2024
OlivierNicole
added a commit
to ocaml-wasm/wasm_of_ocaml
that referenced
this pull request
Sep 12, 2024
OlivierNicole
added a commit
to OlivierNicole/wasm_of_ocaml
that referenced
this pull request
Sep 12, 2024
OlivierNicole
added a commit
to ocaml-wasm/wasm_of_ocaml
that referenced
this pull request
Sep 13, 2024
OlivierNicole
added a commit
to OlivierNicole/wasm_of_ocaml
that referenced
this pull request
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is best reviewed commit by commit. It adds a number of missing conversions, and other changes that have been performed in Wasm_of_ocaml in order to expose number-manipulating functions that are compatible with both the JS and Wasm backends.
This is part of a series of PRs intending to reduce the diff between js_of_ocaml and wasm_of_ocaml.