-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failure on Ubuntu 18.04 unknown type name ‘DWORD’ / ‘CRITICAL_SECTION’ #760
Comments
Resolved by installing Note: |
We better reopen this, because it means that the OS was detected as Windows. I understand that you did |
I tried to recover the list of actions done by |
It seems all the Ubuntu installations I have ready access to are 16.04, so I will set up a VM or container later and try. Thanks for the report. |
I tried with a docker image of 18.04 to install latest lwt, it installed without problems. |
Ok, I will close this for now, then. Lwt builds routinely without conf-libev on 16.04 (e.g., in Travis, and locally on my machine). I'd assume it also builds on 18.04 in most circumstances :) Please do post if you see this problem again. |
* Lwt 5.* wont compile Resolved by installing conf-libev as suggested by ocsigen/lwt#760 * Nested calls to `Lwt_main.run` Lwt 5.* prohibits nested calls of `Lwt_main.run`. Previously every call to `Proc.run` would invoke `Lwt_main.run` which could result in nested calls. To resolve this `Proc.run` no longer calls `Lwt_main.run` rather we now have a function `start : (unit -> 'a Lwt.t) -> 'a` which is called once when the evaluator starts. This requires a change of types for `Proc.run` such that it returns a `Lwt` computation, meaning its signature is now `(unit -> 'a Lwt.t) -> 'a Lwt.t`. As a consequence it is necessary to move `value` from `evalir.ml` into the Lwt monad, because `Proc.atomically` (used in `ApplyPure`) was re-calling the main LWT entry point. Co-authored-by: Simon Fowler <simon@simonjf.com>
This patch is a variant of the one in #761 (comment) See #760, #761.
FYI this was fixed in #761 and released in 5.1.2. |
* Lwt 5.* wont compile Resolved by installing conf-libev as suggested by ocsigen/lwt#760 * Nested calls to `Lwt_main.run` Lwt 5.* prohibits nested calls of `Lwt_main.run`. Previously every call to `Proc.run` would invoke `Lwt_main.run` which could result in nested calls. To resolve this `Proc.run` no longer calls `Lwt_main.run` rather we now have a function `start : (unit -> 'a Lwt.t) -> 'a` which is called once when the evaluator starts. This requires a change of types for `Proc.run` such that it returns a `Lwt` computation, meaning its signature is now `(unit -> 'a Lwt.t) -> 'a Lwt.t`. As a consequence it is necessary to move `value` from `evalir.ml` into the Lwt monad, because `Proc.atomically` (used in `ApplyPure`) was re-calling the main LWT entry point. Co-authored-by: Simon Fowler <simon@simonjf.com>
=== ERROR while compiling lwt.5.1.1 ==========================================#
context 2.0.1 | linux/x86_64 | ocaml-base-compiler.4.08.1 | https://opam.ocaml.org#4585683c
Full log:
The text was updated successfully, but these errors were encountered: