Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modern C and compatibility fixes #1022

Merged
merged 6 commits into from
Jul 27, 2024
Merged

Conversation

MisterDA
Copy link
Contributor

This PR:

  • Fixes modern C89/C99/C11/C17 compilers requiring (void) (no parameter) instead of () (pre C89 any parameter);
  • Fixes mincore detection on BSD and macOS;
  • Fixes a compatibility issue with caml_convert_flag_list taking an int * in OCaml 4 and a const int * in OCaml 5, with a minor header reordering;
  • Fixes a sign comparison warning.

This allows configuring caml headers first, and then overwriting
declarations (for compatibility).
@smorimoto smorimoto merged commit 48abed7 into ocsigen:master Jul 27, 2024
55 checks passed
@MisterDA MisterDA deleted the modern-c branch July 27, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants