Add Lwt_retry library #1032
Merged
Add Lwt_retry library #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shonfeder
commented
Oct 18, 2024
|
Thanks! I'll have a look at the dune version thing this week |
Closed
shonfeder
force-pushed
the
1028/lwt-retry
branch
from
34aefc1 to
71c6731
Compare
|
Rebased on #1035 so I could update the package author and maintainer data. I'll need to rebase on master once that is merged in. The only CI failures remain the FreeBSD and MacOS failures that are occurring in the trunk: |
you can go ahead @shonfeder |
shonfeder
force-pushed
the
1028/lwt-retry
branch
from
71c6731 to
482273d
Compare
Co-authored-by: Raphaël Proust <raphael-proust@users.noreply.github.com>
Also add test to guard against this logic error. Addresses https://github.com/ocsigen/lwt/pull/1032/files/efca0a8174ee9f888c6bbb4beca0258ac639f58c#r1806815960
shonfeder
force-pushed
the
1028/lwt-retry
branch
from
482273d to
63e0837
Compare
|
Rebased! Should be good for a final review and/or merge! Thanks again for the reviews and guidance along the way, @raphael-proust :) |
|
Anything else you'd like to see here @raphael-proust ? |
raphael-proust
requested changes
Nov 4, 2024
raphael-proust
approved these changes
Nov 4, 2024
|
Ready to merge unless the CI shows I messaed up something with my suggested+applied changes |
|
Thank you for the fixes! |
|
Thanks for the contribution!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
Lwt_retrylibrary discussed in #1028 as a separate package. I believe all guidance suggested there by @raphael-proust has been incorporated. Thanks for that!I did not add an
iterfunction, since I think this doesn't add any value over usingLwt_stream.iterdirectly.I've tried to make the code, documentation, and tests consistent with the style I found in other locations in the code base.