Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiniest fix in documentation #827

Merged
merged 2 commits into from
Dec 15, 2020
Merged

Tiniest fix in documentation #827

merged 2 commits into from
Dec 15, 2020

Conversation

raphael-proust
Copy link
Collaborator

A tiny fix, a typo fix really, for the documentation of finalize.

And because I was there I also reworded a bit for uniformity.

@aantron
Copy link
Collaborator

aantron commented Dec 10, 2020

For the remaining CI, you can probably just remove bisect_ppx as a dev dependency (so, remove it completely) from all the .opam files. We converted the PPX to ppxlib in #807, but Bisect's conversion is still going on in aantron/bisect_ppx#327.

@aantron
Copy link
Collaborator

aantron commented Dec 10, 2020

I would suggest a different PR for that. or just a push to master. Also, to add to an earlier comment of mine about squash-merging, this PR is a good candidate for a rebase-merge, since the individual commits can stand on their own in a clean history.

@raphael-proust raphael-proust merged commit 8f8fe92 into ocsigen:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aantron aantron aantron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphael-proust @aantron