removed the unnecessary "ugly cast" from function add_cancel_callback #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I pushed a commit, but it's more of a suggestion. The idea is to use the named type alias ( If you prefer, I'll push it in its own branch and merge it through there. |
|
This change is a good idea, indeed. Thanks. Makes things clearer. No need to add this change somewhere else and then merge it. |
|
@esope I'll rebase this branch on master so that it goes through the newer CI system that landed there. I'll mere it once it passes that CI. |
raphael-proust
force-pushed
the
experimental
branch
from
7e0f2cc
to
b87afe4
Compare
raphael-proust
force-pushed
the
experimental
branch
from
b87afe4
to
dc911b8
Compare
|
I rebased on master and resolved the conflict (which was only in the changelog) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed an unnecessary Obj.magic