Deprecate Lwt_main.yield in favor of Lwt.pause. #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aantron
reviewed
May 25, 2021
aantron
reviewed
May 25, 2021
|
Is there something left to be done? |
|
I rebased the PR and cleaned up the commit history a bit. Anything else I should do? @raphael-proust |
|
Nothing else to do. I made a small change to the CHANGES file. I'll leave enough time for you to let me know if I have messed up something and then I'll merge. Thanks for the contribution! |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially addresses #855. The eventual goal is to remove the second pool completely.
Lwt_unix.auto_pausewas added to replaceLwt_unix.auto_yield.