Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix win32_spawn leaking dev_null fd in the parent process #906

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Fix win32_spawn leaking dev_null fd in the parent process #906

merged 1 commit into from
Dec 2, 2021

Conversation

MisterDA
Copy link
Contributor

No description provided.

@MisterDA MisterDA force-pushed the windows-createprocess-leak-dev-null branch from 02af86a to ec36c97 Compare December 1, 2021 14:09
@MisterDA
Copy link
Contributor Author

MisterDA commented Dec 1, 2021

Added a change entry.

@smorimoto
Copy link
Member

Could you check this @raphael-proust?

@smorimoto
Copy link
Member

I took a close look, but it looks good, so I will merge this.

@smorimoto smorimoto merged commit e9b44ce into ocsigen:master Dec 2, 2021
@MisterDA MisterDA deleted the windows-createprocess-leak-dev-null branch June 9, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smorimoto smorimoto smorimoto approved these changes

@raphael-proust raphael-proust Awaiting requested review from raphael-proust

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MisterDA @smorimoto