Don't define CAML_NAME_SPACE, use mlvalues macros
#929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avsm
reviewed
Feb 6, 2022
MisterDA
force-pushed
the
5.00-cleanups
branch
2 times, most recently
from
dc5b105
to
3b75315
Compare
raphael-proust
added
the
OCaml.5.0.0-readiness
raphael-proust
force-pushed
the
5.00-cleanups
branch
from
b1ad535
to
1121a88
Compare
|
Rebased and added entry to the CHANGES. Will merge once the CI passes. |
raphael-proust
force-pushed
the
5.00-cleanups
branch
from
1121a88
to
043829a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAML_NAME_SPACEhas no more effect in 5.00 as all the functions are prefixed withcaml_and the old names were removed.The mlvalues macros were introduced in 4.12 and help manipulating option and list values in C.