Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bind_error to Lwt_result #943

Merged
merged 5 commits into from
Jun 2, 2022
Merged

Add bind_error to Lwt_result #943

merged 5 commits into from
Jun 2, 2022

Conversation

bn-d
Copy link
Contributor

@bn-d bn-d commented May 12, 2022

There is map vs map_error and there is bind_lwt vs bind_lwt_error. I think having a bind_error would really make sense. This is very usefully when your processes have retry, backup/alternative loading method etc.

Thanks

@raphael-proust
Copy link
Collaborator

The changeset looks good to me. The history can use some squashing. Do you want to do it? Otherwise I can squash and push on your branch. Let me know.

@bn-d
Copy link
Contributor Author

bn-d commented Jun 2, 2022

Let's just squash and push through GitHub. Thanks

@raphael-proust raphael-proust merged commit 3885cf7 into ocsigen:master Jun 2, 2022
@bn-d bn-d deleted the patch-1 branch June 3, 2022 19:47
MisterDA pushed a commit to MisterDA/lwt that referenced this pull request Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants