-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support OCaml 5 new Unix API names #953
Conversation
The upstream OCaml PR was merged - please could someone kick GitHub actions? |
Re-running the analysis step to pickup dune 3.3.0 so this works on OCaml 5.0. Otherwise ocaml-ci should be working for this PR. @dra27 |
I just kicked GitHub Actions. |
a61aaef
to
9d4f2b5
Compare
eb94587
to
56fba76
Compare
The tests require a release of base with janestreet/base#129 (comment) addressed, although temporarily pinning it also revealed a missing symbol shim. With dra27@9d4f2b5b4, this passed ocaml-ci on 5.0 |
Tested locally. It just needs an entry in CHANGES. I'll push a commit for that. Additionally, we could also add a check for |
The ci is somewhat finicky because it's an alpha release. I'm merging this now and may address the CI later. |
I wholeheartedly back adding 5.0 testing to CI 🙂 |
The compiler is considering ensuring all symbols in the Unix library are prefixed
caml_
for 5.0 (ocaml/ocaml#10926).This requires:
unix_exit
orcaml_unix_exit
caml/socketaddr.h
socket_domain_table
andsocket_type_table
internal Unix symbols