Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add <template> tag #239

Merged
merged 2 commits into from
Jan 24, 2020
Merged

Add <template> tag #239

merged 2 commits into from
Jan 24, 2020

Conversation

slegrand45
Copy link
Contributor

@Drup
Copy link
Member

Drup commented May 6, 2019

Thanks, I wanted to add this one!

However, I'm not sure I agree with the typing, I'll have to study it a bit more closely (in particular, the spec and MDN seems to disagree).

Also, please add the link to mdn in the .mli :)

@slegrand45
Copy link
Contributor Author

Link to MDN added.

@Drup Drup merged commit 0ba7ae2 into ocsigen:master Jan 24, 2020
@Drup
Copy link
Member

Drup commented Jan 24, 2020

In the end, the typing seems fine, thanks!

@slegrand45 slegrand45 deleted the tag-template branch February 2, 2020 10:22
Drup added a commit to Drup/opam-repository that referenced this pull request Mar 6, 2020
@Drup
[new release] tyxml-ppx, tyxml-syntax, tyxml and tyxml-jsx (4.4.0)
d2cc2a6 
CHANGES:

* Add support for Reason's JSX syntax with a new `tyxml-jsx` package
  (ocsigen/tyxml#254 by Joris Giovannangeli and Gabriel Radanne
   with help from Ulrik Strid and Louis Roché)
* Modernize the handling of toplevel printers for utop.
  (Gabriel Radanne)

## Elements and attributes

* Add `allowfullscreen`, `allowpaymentrequest`, `referrerpolicy` attributes
  (ocsigen/tyxml#242 by Thibault Suzanne)
* Allow `crossorigin` attribute for script element
  (ocsigen/tyxml#243 by Thibault Suzanne)
* Greatly improved support of whitespaces in the PPX
  (ocsigen/tyxml#225 by Jules Aguillon)
* Add preliminary support for ARIA attributes
  (ocsigen/tyxml#253 by Stéphane Legrand and Gabriel Radanne)
* Add `template` element
  (ocsigen/tyxml#239 Stéphane Legrand)

* Several bug fixes for types and PPX
Drup added a commit to Drup/opam-repository that referenced this pull request Mar 6, 2020
@Drup
[new release] tyxml-ppx, tyxml-syntax, tyxml and tyxml-jsx (4.4.0)
d544417 
CHANGES:

* Add support for Reason's JSX syntax with a new `tyxml-jsx` package
  (ocsigen/tyxml#254 by Joris Giovannangeli and Gabriel Radanne
   with help from Ulrik Strid and Louis Roché)
* Modernize the handling of toplevel printers for utop.
  (Gabriel Radanne)

## Elements and attributes

* Add `allowfullscreen`, `allowpaymentrequest`, `referrerpolicy` attributes
  (ocsigen/tyxml#242 by Thibault Suzanne)
* Allow `crossorigin` attribute for script element
  (ocsigen/tyxml#243 by Thibault Suzanne)
* Greatly improved support of whitespaces in the PPX
  (ocsigen/tyxml#225 by Jules Aguillon)
* Add preliminary support for ARIA attributes
  (ocsigen/tyxml#253 by Stéphane Legrand and Gabriel Radanne)
* Add `template` element
  (ocsigen/tyxml#239 Stéphane Legrand)

* Several bug fixes for types and PPX
Drup added a commit to Drup/opam-repository that referenced this pull request Mar 6, 2020
@Drup
[new release] tyxml-ppx, tyxml-syntax, tyxml and tyxml-jsx (4.4.0)
8f0ae27 
CHANGES:

* Add support for Reason's JSX syntax with a new `tyxml-jsx` package
  (ocsigen/tyxml#254 by Joris Giovannangeli and Gabriel Radanne
   with help from Ulrik Strid and Louis Roché)
* Modernize the handling of toplevel printers for utop.
  (Gabriel Radanne)

## Elements and attributes

* Add `allowfullscreen`, `allowpaymentrequest`, `referrerpolicy` attributes
  (ocsigen/tyxml#242 by Thibault Suzanne)
* Allow `crossorigin` attribute for script element
  (ocsigen/tyxml#243 by Thibault Suzanne)
* Greatly improved support of whitespaces in the PPX
  (ocsigen/tyxml#225 by Jules Aguillon)
* Add preliminary support for ARIA attributes
  (ocsigen/tyxml#253 by Stéphane Legrand and Gabriel Radanne)
* Add `template` element
  (ocsigen/tyxml#239 Stéphane Legrand)

* Several bug fixes for types and PPX
@Drup Drup mentioned this pull request Mar 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slegrand45 @Drup