Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the popover API and for the name attribute on details elements. #341

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SylvainBoilard
Copy link

@SylvainBoilard SylvainBoilard commented Nov 4, 2024

@Drup
Copy link
Member

Drup commented Nov 8, 2024

Thanks !

If I'm reading the spec right, toggle is a valid event for any popover element ... which can be any HTML element. In that case, ontoggle should be a global attribute.

Is that right ? Can you do the modification accordingly ?

@SylvainBoilard SylvainBoilard changed the title Add name and ontoggle attributes for details HTML elements. Add support for the popover API and for the name attribute on <details> elements. Nov 14, 2024
@SylvainBoilard
Copy link
Author

Yes that is absolutely right; I had initially planned to limit the scope of this PR to the details element but following your input I decided to update it to support the popover API.

@SylvainBoilard SylvainBoilard changed the title Add support for the popover API and for the name attribute on <details> elements. Add support for the popover API and for the name attribute on details elements. Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants