Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Default should always be last #11

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Bug: Default should always be last #11

merged 1 commit into from
Sep 6, 2022

Conversation

curtdept
Copy link
Contributor

@curtdept curtdept commented Sep 6, 2022

@octet-stream default should be last :)

This ends up breaking webpack with got, etc.

@octet-stream
Copy link
Owner

Oh, right, thank you!

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #11 (6fee944) into master (f055fee) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #11   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          553       553           
  Branches        78        78           
=========================================
  Hits           553       553           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@octet-stream octet-stream merged commit b25daf7 into octet-stream:master Sep 6, 2022
@octet-stream
Copy link
Owner

@curtdept
Copy link
Contributor Author

curtdept commented Sep 6, 2022

@octet-stream awesome, thanks for the quick merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants