Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix norm gym wrapper #15

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Fix norm gym wrapper #15

merged 2 commits into from
Dec 21, 2023

Conversation

kpertsch
Copy link
Collaborator

Fixes bugs in normalization wrapper -- these bugs affected rollouts of policies trained with "bound" normalization (Octo does not use this) or with "normal" normalization if conditioned on proprio (which Octo by default is not).

octo/utils/gym_wrappers.py Outdated Show resolved Hide resolved
octo/utils/gym_wrappers.py Outdated Show resolved Hide resolved
@kpertsch
Copy link
Collaborator Author

Added support for masks and value clipping to normalization wrapper to mirror dataset normalization routine

Copy link
Collaborator

@dibyaghosh dibyaghosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kpertsch kpertsch merged commit 566d775 into main Dec 21, 2023
1 check passed
@kpertsch kpertsch deleted the fix_norm_wrapper branch December 21, 2023 06:26
kvablack pushed a commit that referenced this pull request Dec 22, 2023
kvablack pushed a commit that referenced this pull request Dec 22, 2023
kvablack pushed a commit that referenced this pull request Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants