Fix pad_mask bug: min instead of max for pad_length #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HomerW
approved these changes
Apr 9, 2024
|
Gotcha, no worries! I don't think I have permissions to merge this branch. Feel free to merge it yourself or do whatever is needed to get the change updated on the main branch. Thanks Homer! |
WenchangGaoT
pushed a commit
to WenchangGaoT/octo1
that referenced
this pull request
May 10, 2024
Added encoders for more pure transformer models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the
pad_maskin observations with history is always allTrues. However, we would want part of thepad_maskto beFalseduring the first few timesteps when the number of past observations is shorter than the horizon length.