Add a webhook to validate trust policies #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmoor
force-pushed
the
validate-webook2
branch
from
601b330 to
ad37a73
Compare
mattmoor
commented
May 18, 2024
| default = "chainguard/octo-sts:latest" | ||
| type = object({ | ||
| app = optional(string, "chainguard/octo-sts:latest") | ||
| webhook = optional(string, "chainguard/octo-sts-webhook:latest") |
There was a problem hiding this comment.
This doesn't exist yet (obviously), but we'll need to create it once we cut the next release!
|
cc @wlynch |
Since we don't give any information at request time about why a STS policy is valid or not so that we don't leak details about the policy, this webhook will validate on the repo at pull request / push so the repo authors get feedback on potential config issues.
mattmoor
force-pushed
the
validate-webook2
branch
from
ad37a73 to
fc6d457
Compare
tcnghia
approved these changes
May 18, 2024
imjasonh
reviewed
May 20, 2024
| @@ -0,0 +1,57 @@ | |||
| // Generate a random webhook secret | |||
| resource "random_password" "webhook-secret" { | |||
There was a problem hiding this comment.
Is something supposed to pass this secret to GitHub somehow? Or is this supposed to be an input instead of a randomly generated internal thing? I don't understand how app installation webhooks are secured.
There was a problem hiding this comment.
Yeah, basically we need to access the secret and feed it into github when we register the webhook portion of things.
Since the webhook reads this at startup I went this route mostly for bootstrapping purposes. I really wish github would switch to a model more like ours.
|
Credit to @wlynch I just made some tweaks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on Billy's PR, but I've rebased it on #284 and expanded it a bunch based on some experimentation in my dev environment.
Draft until we land the base PR.
Fixes: #247
Fixes: #46