Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add array views support to MailFake #548

Closed
wants to merge 5 commits into from
Closed

Add array views support to MailFake #548

wants to merge 5 commits into from

Conversation

mjauvin
Copy link
Contributor

@mjauvin mjauvin commented Dec 15, 2020 •
edited
Loading

@bennothommo
Copy link
Contributor

Blocked by octobercms/october#5402

@mjauvin
Copy link
Contributor Author

mjauvin commented Dec 17, 2020

@bennothommo this is related but not DEPENDENT on the other PR.

@LukeTowers LukeTowers self-assigned this Dec 17, 2020
@mjauvin
Copy link
Contributor Author

mjauvin commented Dec 18, 2020

can this be added to 1.1.2 milestone?

@bennothommo
Copy link
Contributor

bennothommo commented Dec 18, 2020 •
edited
Loading

@mjauvin I'm still going to consider this blocked until the other PR is merged, so we can ensure these tests are still passing with that PR in place.

@bennothommo bennothommo added this to the v1.1.2 milestone Dec 18, 2020
@github-actions
Copy link

This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this is still being worked on, please respond and we will re-open this pull request.
If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

@mjauvin
Copy link
Contributor Author

mjauvin commented Feb 17, 2021

ping

@mjauvin mjauvin mentioned this pull request Mar 17, 2021
Merged
@mjauvin mjauvin closed this Mar 26, 2021
LukeTowers pushed a commit to wintercms/storm that referenced this pull request Mar 28, 2021
@mjauvin
Add array views support to MailFake (#7)
01de449 
Related to wintercms/winter#45

ref. octobercms/library#548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennothommo bennothommo bennothommo approved these changes

Assignees

@LukeTowers LukeTowers

Labels
Status: Blocked Type: Maintenance
Milestone
v1.1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@mjauvin @bennothommo @LukeTowers