Rebase October CMS on Laravel 6 #4893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and minimum password length requirements
…ers representing minutes as 5.8 changed integers into meaning seconds instead.
…calling the variable now
Temporarily removed the October subsplits until they are supporting L6.
Signature for the `where` method changes in L6, so a wrapper has been put in place.
This allows the home page to load.
Prevents conflicts with unit tests that might use another auth system, ie. Passport. Hat tip to @LukeTowers for pointing out my shame.
A field widget that allows for entering of sensitive information that can be revealed at the user's request - ie. API keys, secrets. When a sensitive field that has been previously populated is loaded again, a placeholder is used instead of the real value, until the user opts to reveal the value. The real value is loaded via AJAX. Credit to @tomaszstrojny for the original implementation. Replaces #5062. Fixes #5061, #1850, perhaps #1061. Co-authored-by: Tomasz Strojny <tomasz@init.biz> Co-authored-by: Luke Towers <github@luketowers.ca>
This will redirect any instances of the now-removed Input facade from Laravel to the Rain library's Input facade.
…5212) Co-authored-by: Luke Towers <github@luketowers.ca>
…ersions from accidentally pulling in the L6 update
LukeTowers
reviewed
Jul 19, 2020
Instead of using a temporary file to allow checks with `realpath()` to succeed, use the new `resolve_path()` helper added in octobercms/library@a9a629b to replace the `realpath()` usage and allow for path resolution of files that don't exist yet. This will allow new asset files to still be saved correctly, whilst still preventing paths outside of the assets directory to be used. Replaces b1954e9.
LukeTowers
added
Status: Completed
and removed
Status: In Progress
Testing Needed
help wanted
labels
LukeTowers
added a commit
that referenced
this pull request
Aug 9, 2020
This reverts commit ee0065d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4381. Related Rain library PR: octobercms/library#456. Related docs PR: octobercms/docs#446
This PR represents the current progress for rebasing October CMS on the Laravel 6 framework. This PR can be considered an "early beta" release. It is not recommended for use on production installations, however, we would encourage users to test this out on development copies in preparation for the upgrade.
Release notes and required changes can be found here.
New minimum requirements
Testing
We would appreciate any assistance with testing from the community. If you are interested in testing this out, please follow the below steps to quickly get a fresh instance of the CMS running.
Testing on existing projects
Follow the Upgrade Notes here: https://github.com/octoberrain/meta/blob/master/l6-upgrade-notes.md
Testing on fresh instance
git clone git@github.com:octobercms/october.gitcomposer installphp artisan october:envhttp://127.0.0.1:8000php artisan key:generate --showand copy and paste the value generated here.sqlitestorage/database.sqlitetouch storage/database.sqlitephp artisan october:upphp artisan serveThis will allow you to review the CMS in the following contexts:
Reporting bugs and issues
At this stage, do not create a new issue on GitHub if you spot any issues. Please report the issue as a comment to #4381, which we are using to track progress on the task.