Add support for the DS record #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updated tests to add a new DS record for a sub zone along with updates since an existing DS records is now handled
|
Is superseded by #50 if octodns/octodns#1065 is merged |
We'll need to stick with this one for now since it will work with older versions of octoDNS. Once octodns/octodns#1065 (review) is merged and released we can merge #50 if/when we're OK with putting a hard requirement on the (new) version of octoDNS. |
ross
approved these changes
Sep 19, 2023
|
Thanks |
|
Thank you for merging it (and doing so so quickly)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated tests to add a new DS record for a sub zone along with updates since an existing DS records is now handled