Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DS record support #83

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Add DS record support #83

merged 1 commit into from
Feb 5, 2024

Conversation

rasturic
Copy link
Contributor

@rasturic rasturic commented Feb 4, 2024

  • Add DS record support
  • Confirmed code coverage
  • Tested against AWS Route53 account: Create, Update and Delete. Single and multiple values.

ross
ross approved these changes Feb 4, 2024
View reviewed changes
Copy link
Contributor

@ross ross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please add an entry to CHANGELOG.md about the added support and it should be ready to 🚢

@rasturic
Copy link
Contributor Author

rasturic commented Feb 5, 2024

Got it. Thanks @ross.

ross
ross approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@ross ross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ross ross merged commit 9dff89b into octodns:main Feb 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ross ross ross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rasturic @ross